Seeing as I'm not the only person interested in this feature I'm happy to put a bit of effort into making the code more acceptable. I've hit a couple of issues that I could do with some support on though:
- When I check out the repository (rather than downloading the src zip) and follow the build instructions I don't get a release zip built that I can install. - I have to build the project with the tests disabled because "testGetMimeTypesFileGlob" always fails (trace attached). Thanks, Joel. -- Dr Joel Wright IT Innovation Centre Gamma House Enterprise Road Southampton SO16 7NS, UK Tel.:+44 23 8059 8866 mailto:[email protected] http://www.it-innovation.soton.ac.uk/ ________________________________ From: Stian Soiland-Reyes [[email protected]] Sent: 22 May 2012 10:23 To: List for general discussion and hacking of the Taverna project Subject: Re: [Taverna-hackers] REST Services and Optional Query String Parameters On Mon, May 21, 2012 at 2:20 PM, Joel Wright <[email protected]<mailto:[email protected]>> wrote: The patch is undoubtedly not the best method for adding the functionality I was after (I feel embarrassed even sending a patch that catches and ignores exceptions), but given the structure of the code it was certainly the lightest-touch I could come up with. Thanks for your patch. Unfortunately the code still needs a bit of work. You should not eat any exception from the reference service. This could hide lots of different errors, such as it being a binary, and inadvertently make a slightly different REST call that the user did not expect. Rather, to see if an input is provided, you should check if the "inputs" map has the inputName key, and just do a continue if not. (or iterate over the inputs map, and check if it is an expected activity input). This would need a good set of unit tests so that we can verify that this works as intended, and only where intended. Tests should cover edge-cases like http://example.com/?a=1&b=/fred/{soup}&c=3 and http://example.com/?{soup}={value} As the old behaviour was failure on any missing parameter, I don't think this patch will be breaking any backward comparability. -- Stian Soiland-Reyes, myGrid team School of Computer Science The University of Manchester
taverna-build-fail.gz
Description: taverna-build-fail.gz
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ taverna-hackers mailing list [email protected] Web site: http://www.taverna.org.uk Mailing lists: http://www.taverna.org.uk/about/contact-us/ Developers Guide: http://www.taverna.org.uk/developers/
