henry pushed to branch tor-browser-148.0a1-16.0-2 at The Tor Project / Applications / Tor Browser
Commits: b8ef1320 by Stephanie Cunnane at 2026-03-10T09:41:41+00:00 Bug 2020410 - Ensure search suggestions checkbox on about:preferences#search is hidden when browser.urlbar.quicksuggest.enabled is false. r=Standard8,hjones Differential Revision: https://phabricator.services.mozilla.com/D285898 - - - - - 1 changed file: - browser/components/preferences/search.js Changes: ===================================== browser/components/preferences/search.js ===================================== @@ -501,15 +501,39 @@ Preferences.addSetting({ }, }); +function determineSuggestionSettingsVisibility() { + if (!lazy.UrlbarPrefs.get("quickSuggestEnabled")) { + return false; + } else if ( + lazy.UrlbarPrefs.get("quickSuggestSettingsUi") == + lazy.QuickSuggest.SETTINGS_UI.NONE + ) { + return false; + } + return true; +} + Preferences.addSetting({ id: "firefoxSuggestAll", pref: "browser.urlbar.suggest.quicksuggest.all", + deps: [ + "quickSuggestEnabledPref", + "quickSuggestSettingsUiPref", + "nimbusListener", + ], + visible: determineSuggestionSettingsVisibility, }); Preferences.addSetting({ id: "firefoxSuggestSponsored", pref: "browser.urlbar.suggest.quicksuggest.sponsored", - deps: ["firefoxSuggestAll"], + deps: [ + "firefoxSuggestAll", + "quickSuggestEnabledPref", + "quickSuggestSettingsUiPref", + "nimbusListener", + ], + visible: determineSuggestionSettingsVisibility, disabled: deps => { return !deps.firefoxSuggestAll.value; }, @@ -525,6 +549,14 @@ Preferences.addSetting({ "nimbusListener", ], visible: () => { + if (!lazy.UrlbarPrefs.get("quickSuggestEnabled")) { + return false; + } else if ( + lazy.UrlbarPrefs.get("quickSuggestSettingsUi") == + lazy.QuickSuggest.SETTINGS_UI.NONE + ) { + return false; + } return ( lazy.UrlbarPrefs.get("quickSuggestSettingsUi") == lazy.QuickSuggest.SETTINGS_UI.FULL @@ -561,6 +593,13 @@ Preferences.addSetting( Preferences.addSetting({ id: "dismissedSuggestionsDescription", + deps: [ + "firefoxSuggestAll", + "quickSuggestEnabledPref", + "quickSuggestSettingsUiPref", + "nimbusListener", + ], + visible: determineSuggestionSettingsVisibility, }); const ENGINE_FLAVOR = "text/x-moz-search-engine"; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b8ef13204a6378717bf324da3d30621b283eb966 -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b8ef13204a6378717bf324da3d30621b283eb966 You're receiving this email because of your account on gitlab.torproject.org.
_______________________________________________ tbb-commits mailing list -- [email protected] To unsubscribe send an email to [email protected]
