Re: [tboot-devel] [PATCH] TSS_RESULT not checked in lcptools.c

[Michael Gissing]

I'm sorry, my Patch of lcptools.c wasn't proper. I found more missing checks, 
here's my next try.

greetz Michael



diff --git a/lcptools/lcptools.c b/lcptools/lcptools.c
--- a/lcptools/lcptools.c
+++ b/lcptools/lcptools.c
@@ -90,7 +90,7 @@
      CHECK_TSS_RETURN_VALUE("init_tss_context", result, ret);

      if ( passwd != NULL ) {
-        set_tpm_secret(hcontext, &htpm, &hpolicy, passwd, passwd_length);
+        result = set_tpm_secret(hcontext, &htpm, &hpolicy, passwd, 
passwd_length);
          CHECK_TSS_RETURN_VALUE("set_tpm_secret", result, ret);
      }

@@ -105,7 +105,7 @@
       * if the nv object need authentication
       */
      if ( auth != NULL ) {
-        set_nv_secret(hcontext, hnvstore, &hpolobj, auth, auth_length);
+        result = set_nv_secret(hcontext, hnvstore, &hpolobj, auth, 
auth_length);
          CHECK_TSS_RETURN_VALUE("set_nv_secret", result, ret);
      }

@@ -153,6 +153,7 @@
                  result, ret);

          result = Tspi_NV_DefineSpace(hnvstore, 0, hwrtpcrcomp);
+        CHECK_TSS_RETURN_VALUE("Tspi_NV_DefineSpace failed", result, ret);
      } else {
          /*
           * Set the locality number.
@@ -253,7 +254,7 @@


      if ( passwd != NULL ) {
-        set_tpm_secret(hcontext, &htpm, &hpolicy, passwd, passwd_length);
+        result = set_tpm_secret(hcontext, &htpm, &hpolicy, passwd, 
passwd_length);
          CHECK_TSS_RETURN_VALUE("set_tpm_secret", result, ret);
      }

@@ -343,7 +344,7 @@
              result, ret);

      if ( password != NULL ) {
-        set_nv_secret(hcontext, hnvstore, &hnvpol, password, pwd_length);
+        result = set_nv_secret(hcontext, hnvstore, &hnvpol, password, 
pwd_length);
          CHECK_TSS_RETURN_VALUE("set_nv_secret", result, ret);
      }

@@ -446,7 +447,7 @@
              result, ret);

      if ( password != NULL ) {
-        set_nv_secret(hcontext, hnvstore, &hnvpol, password, pwd_length);
+        result = set_nv_secret(hcontext, hnvstore, &hnvpol, password, 
pwd_length);
          CHECK_TSS_RETURN_VALUE("set_nv_secret", result, ret);
      }

@@ -956,7 +957,7 @@


      if ( password != NULL ) {
-        set_tpm_secret(hcontext, &htpm, &hpolicy, password, passwd_length);
+        result = set_tpm_secret(hcontext, &htpm, &hpolicy, password, 
passwd_length);
          CHECK_TSS_RETURN_VALUE("set_tpm_secret", result, ret);
      }
      else {


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel