Ok, I found the problem with the Makefile. On Ubuntu, /bin/sh is linked
to /bin/dash. So when you run a command in the Makefile, it is
interpreted by Dash. However, Dash does not support "echo -e". I guess a
portable workaround would be to use "printf" instead (patch attached).
Fred
Signed-off-by: Frederic Guihery<sy...@cat-lan.com>
diff -r a5db79cb4fb8 lcptools/Makefile
--- a/lcptools/Makefile Tue Jul 27 01:54:29 2010 -0700
+++ b/lcptools/Makefile Tue Jul 27 13:55:26 2010 +0200
@@ -75,7 +75,7 @@
#
trousers_dep:
- @echo -e "#include <trousers/tss.h>" | $(CC) -x c $(CFLAGS)
$(LDFLAGS) $(LIBS) - -Wl,--defsym=main=0 -o $@ >/dev/null 2>&1 || (echo
trousers-devel package is not installed && false)
+ @printf "#include <trousers/tss.h>\n" | $(CC) -x c $(CFLAGS)
$(LDFLAGS) $(LIBS) - -Wl,--defsym=main=0 -o $@ >/dev/null 2>&1 || (echo
trousers-devel package is not installed && false)
#
# dependencies
On Mon, 26 Jul 2010 19:31:11 -0700, "Cihula, Joseph"
<joseph.cih...@intel.com> wrote:
> I applied the fix for lcptools.c (with a small change to cast to size_t).
>
> The change for lcptools/Makefile, however cause my system to fail to
> detect that trousers is not installed and thus causes a bunch of
> compilation errors. Please give more information as to how/why the
> current version of the Makefile is failing for you.
>
> Joe
>
>> -----Original Message-----
>> From: Frédéric Guihéry [mailto:sy...@cat-lan.com]
>> Sent: Monday, July 26, 2010 2:02 PM
>> To: tboot-devel@lists.sourceforge.net
>> Subject: Re: [tboot-devel] [PATCH] fix build errors
>>
>> With the attached file, it should be better.
>>
>> Le 26/07/2010 22:54, Frédéric Guihéry a écrit :
>> > Hi,
>> >
>> > Here is a tiny patch that fixes some issues I met building tboot.
>> >
>> > Kind regards,
>> > Frederic Guihery
>> >
>> > Signed-off-by: Frederic Guihery<sy...@cat-lan.com>
>> >
>> >
>> > diff -r 57ea1beb3bc8 lcptools/Makefile
>> > --- a/lcptools/Makefile Thu Jul 22 22:19:08 2010 -0700
>> > +++ b/lcptools/Makefile Mon Jul 26 22:33:28 2010 +0200
>> > @@ -75,7 +75,7 @@
>> > #
>> >
>> > trousers_dep:
>> > - @echo -e "#include<trousers/tss.h>" | $(CC) -x c $(CFLAGS)
>> > $(LDFLAGS) $(LIBS) - -Wl,--defsym=main=0 -o $@>/dev/null 2>&1 || (echo
>> > trousers-devel package is not installed&& false)
>> > + @echo -e "#include<trousers/tss.h>" | $(CC) -x c $(CFLAGS)
>> > $(LDFLAGS) $(LIBS) -Wl,--defsym=main=0 -o $@>/dev/null 2>&1 || (echo
>> > trousers-devel package is not installed&& false)
>> >
>> > #
>> > # dependencies
>> > diff -r 57ea1beb3bc8 lcptools/lcptools.c
>> > --- a/lcptools/lcptools.c Thu Jul 22 22:19:08 2010 -0700
>> > +++ b/lcptools/lcptools.c Mon Jul 26 22:33:28 2010 +0200
>> > @@ -736,7 +736,7 @@
>> > pcr_length = select + sizeof(select)
>> > + sizeof(TPM_LOCALITY_SELECTION) +
>> > SHA1_HASH_LEN;
>> > /* check whether the data input is long enough */
>> > - if ( (pcr_length + (pread_data - src.listdata) -2)
>> > + if ( (pcr_length + (uint32_t)(pread_data -
>> > src.listdata) - 2)
>> > > src.listdata_length ) {
>> > log_error("the policy list data is not correct\n");
>> > result = LCP_E_COMD_INTERNAL_ERR;
>> >
diff -r a5db79cb4fb8 lcptools/Makefile
--- a/lcptools/Makefile Tue Jul 27 01:54:29 2010 -0700
+++ b/lcptools/Makefile Tue Jul 27 13:55:43 2010 +0200
@@ -75,7 +75,7 @@
#
trousers_dep:
- @echo -e "#include <trousers/tss.h>" | $(CC) -x c $(CFLAGS) $(LDFLAGS)
$(LIBS) - -Wl,--defsym=main=0 -o $@ >/dev/null 2>&1 || (echo trousers-devel
package is not installed && false)
+ @printf "#include <trousers/tss.h>\n" | $(CC) -x c $(CFLAGS) $(LDFLAGS)
$(LIBS) - -Wl,--defsym=main=0 -o $@ >/dev/null 2>&1 || (echo trousers-devel
package is not installed && false)
#
# dependencies
------------------------------------------------------------------------------
The Palm PDK Hot Apps Program offers developers who use the
Plug-In Development Kit to bring their C/C++ apps to Palm for a share
of $1 Million in cash or HP Products. Visit us here for more details:
http://ad.doubleclick.net/clk;226879339;13503038;l?
http://clk.atdmt.com/CRS/go/247765532/direct/01/
_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel
