> > >> +#define XENPF_enter_acpi_sleep 51
> > >> +struct xenpf_enter_acpi_sleep {
> > >> + /* IN variables */
> > >> + uint16_t pm1a_cnt_val; /* PM1a control value. */
> > >> + uint16_t pm1b_cnt_val; /* PM1b control value. */
> > > These are uint32_t in native Linux--why truncate in the API and not at
> > > use?
> >
> > Does ACPI define them as 32 or 16 bit?
>
> The spec indicates that the length is variable and could be up to 32 bits
> (AFAICT). And Linux uses 32b, which your other patch is truncating for this
> call.
Yikes! Well, looks like we need to fix the Xen ABI too. Lets get that fixed
and also address all the other comments (thanks for looking at it) you pointed
out.
------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel
