On 03/19/2013 07:14 PM, Ren, Qiaowei wrote:
> Any comments on this patch?
>
> Thanks,
> Qiaowei
The biggest question is probably if we can use an existing hook of some
sort.
Overriding the apic method is probably not the right way to go, though.
tglx, do you have any opinions here?
Furthermore, this really is not nice:
> +int tboot_wake_up(int apicid, unsigned long sipi_vec) {
> + if (!tboot_enabled())
> + return 0;
> +
> + if ((tboot->version < 6) ||
> + !(tboot->flags & TB_FLAG_AP_WAKE_SUPPORT))
> + return 0;
> +
> + tboot->ap_wake_addr = sipi_vec;
> + tboot->ap_wake_trigger = apicid;
> +
> + return 1;
> +}
Not only don't you set boot_error for the code above it, but there is
absolutely no indication how that does its job (are those active
operations? If so they should use writel()), nor does it include any
kind of synchronization.
-hpa
------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
tboot-devel mailing list
tboot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/tboot-devel
