Thanks Ning, That makes sense. And it worked on my system. Nice short fix.
Thanks for the fast response. Much appreciated! -----Original Message----- From: Sun, Ning [mailto:ning....@intel.com] Sent: Monday, May 18, 2015 12:34 PM To: Ahmed, Safayet (GE Global Research); tboot-devel@lists.sourceforge.net Subject: RE: Checking launch status Hi Safayet, Thanks very much for bringing this up, tboot has the limitation of assumption running on Intel IA platform. As tboot may have chance to run on non-Intel TXT platform, we made an enhancement to tboot to address your questions, the patch is upstreamed to tboot source tree , please feel free to try and test. Regards, -Ning Intel Open Source Technology Center Intel Corporation 3621 Juliette Lane Santa Clara, CA 95054 www.intel.com -----Original Message----- From: Ahmed, Safayet (GE Global Research) [mailto:safayet.ah...@ge.com] Sent: Tuesday, May 12, 2015 3:40 PM To: tboot-devel@lists.sourceforge.net Subject: [tboot-devel] Checking launch status I had some questions about the source: What is the expected behavior of the "is_launched" function on non-TXT platforms? "is_launched" is a wrapper function which calls "txt_is_launched" which reads the TXT.STS configuration register. At multiple locations, tboot attempts to read TXT configuration registers without confirming that the system is a TXT-enabled processor or chipset. I noticed that this was not the case in the tboot code on much earlier versions of tboot. I am looking at how tboot behaves on an AMD system . Based on what I saw in my kernel's dmesg output, the 0xfed30000 physical addresses are not defined in the E820 map. I made minor modifications to the tboot code and noticed that in both the "begin_launch" and "shutdown" functions where "is_launched" is called, "is_launched" is returning true. I am wondering if the "is_launched" function is absolutely necessary in the locations I mentioned and if there is a way around it. Thanks, Safayet ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ tboot-devel mailing list tboot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tboot-devel ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ tboot-devel mailing list tboot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/tboot-devel
