No opposition from me. I think maybe only the spring container tests use that stuff, but I'm 100% sure about that.
> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:tc-dev- > [EMAIL PROTECTED] On Behalf Of Geert Bevin > Sent: Thursday, June 14, 2007 12:36 AM > To: [email protected] > Subject: [tc-dev] Standard included logging jars by WARBuilder > > Hi, > > I'm looking through how wars are built by our container test framework > and I see that commons-logging and log4j are always included by > default: > > public WARBuilder(String warFileName, File tempDir, TestConfigObject > config) { > this.warFileName = warFileName; > this.tempDirPath = new FileSystemPath(tempDir); > this.testConfig = config; > > addDirectoryOrJARContainingClass(WARBuilder.class); // test framework > addDirectoryOrJARContainingClass(LogFactory.class); // commons- > logging > addDirectoryOrJARContainingClass(Logger.class); // log4j > } > > Shouldn't this be dependent on the container that is actually being > tested. Afaik, nowadays, these logging jars are included in most web > containers by default, and it's not recommended to have several of > them in the classpath. > > What do you think? > > Geert > > -- > Geert Bevin > Terracotta - http://www.terracotta.org > Uwyn "Use what you need" - http://uwyn.com > RIFE Java application framework - http://rifers.org > Music and words - http://gbevin.com > _______________________________________________ > tc-dev mailing list > [email protected] > http://lists.terracotta.org/mailman/listinfo/tc-dev _______________________________________________ tc-dev mailing list [email protected] http://lists.terracotta.org/mailman/listinfo/tc-dev
