Inventory Demo: Product.java is not well written
------------------------------------------------

                 Key: CDV-352
                 URL: https://jira.terracotta.org/jira//browse/CDV-352
             Project: Community Development
          Issue Type: Bug
            Reporter: Taylor Gautier
         Assigned To: Issue Review Board


Product.java contains a public non-final field for price.  In general this 
isn't a very good practice, but with Terracotta it's particularly bad.

Product.java needs to be rewritten so that there are proper getters and setters 
for the price, with synchronization and a read-lock for the getter.  I also 
don't agree with the particular code style for the setter which could be 
re-written as a synchronized method call. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.terracotta.org/jira//secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
tc-dev mailing list
[email protected]
http://lists.terracotta.org/mailman/listinfo/tc-dev

Reply via email to