Sounds like it would be a good idea to remove or refactor it. To me
it looks like it does serve a purpose: easily generating calls
manager methods during bytecode instrumentation. However, that could
simply be a method of ByteCodeUtil.
It's a bit moot though, 'cause:
spec.getManagerHelper().callManagerMethod("beginLock", mv);
Is less readable for me in the middle of ASM bytecode instructions than:
mv.visitMethodInsn(INVOKESTATIC, ManagerUtil.CLASS, "beginLock",
"(Ljava/lang/String;I)V");
I'd just remove it :-)
On 16 Oct 2007, at 07:43, Tim Eck wrote:
> No reason really, except that exception gets thrown :-)
>
> That ManagerHelper thing is really old now. It was useful [way]
> back when there were two different ways to make Manager calls
> (static and non-static).
>
> I’d say we could tear it out (if it helps), or maybe don't overload
> the method -- maybe it's just me, but overloaded methods make for
> easy bugs sometimes (esp. if one of the variants take Object arg)
>
> > -----Original Message-----
> > From: [EMAIL PROTECTED] [mailto:tc-dev-
> > [EMAIL PROTECTED] On Behalf Of Saravanan Subbiah
> > Sent: Monday, October 15, 2007 6:28 PM
> > To: [email protected]
> > Subject: [tc-dev] Overloading ManagerUtil methods ?
> >
> > Any reason I cant overload ManagerUtil methods ? I get this
> exception.
> >
> > WARN Exception in thread "main" java.lang.RuntimeException:
> > Duplicated method name [lookupObject] on interface
> > com.tc.object.bytecode.ManagerUtil
> > WARN at
> > com.tc.object.bytecode.ManagerHelperFactory.findMethods
> (ManagerHelperFa
> > ctory.java:40)
> > WARN at
> > com.tc.object.bytecode.ManagerHelperFactory.<init>
> (ManagerHelperFactory
> > .java:26)
> > WARN at
> > com.tc.object.config.StandardDSOClientConfigHelperImpl.<init>
> (StandardD
> > SOClientConfigHelperImpl.java:109)
> > WARN at
> > com.tc.object.tools.BootJarTool.main(BootJarTool.java:2446)
> >
> > --
> > This e-mail incorporates Terracotta's confidentiality policy,
> which is
> > online at http://www.terracottatech.com/emailconfidentiality.shtml
> >
> > _______________________________________________
> > tc-dev mailing list
> > [email protected]
> > http://lists.terracotta.org/mailman/listinfo/tc-dev
>
> _______________________________________________
> tc-dev mailing list
> [email protected]
> http://lists.terracotta.org/mailman/listinfo/tc-dev
--
Geert Bevin
Terracotta - http://www.terracotta.org
Uwyn "Use what you need" - http://uwyn.com
RIFE Java application framework - http://rifers.org
Music and words - http://gbevin.com
_______________________________________________
tc-dev mailing list
[email protected]
http://lists.terracotta.org/mailman/listinfo/tc-dev
