<sigh>. My $0.02, which is my official stance ;-), and which I hate to
even add, since I can't stand religious wars about formatting, is that
if at all possible you should strive to just be as close to something
else as possible. Eliminates most problems. So I recommend any changes
we make should move us closer to, not further away from, the already
established Java standards.
That said, I hate the Java standards in a few areas, and so I realize
there will be exceptions, but generally speaking these kinds of things
are all about personal preference, and there will be no way to make
everyone happy, which is why it's better to just use something else than
to forge your own path.
Like I said, my $0.02 which is worth not even that much probably.
The following is my own personal preference, and has nothing to do with
my official stance. I am not necessarily voting for it, since I don't
have a strong opinion on this other than if you ask me what I prefer,
this is what I will say. Since no one specifically asked, I stand by my
official statement - go with something standard. If you're still
reading, thanks :) I for one think column formatting in general is
atrocious, so I would vote for it to go away. As for formatting
methods, chop-down is the easiest to read,
im-astoundingly-super-awesome-o. A few years ago I noticed that all
code that uses the opening curly brace on the same line usually has a
blank line immediately after, presumably for readability. So I noted
that it's simply easier to just use an open brace on the next line,
instead of on the same line. So for classes and methods I prefer it on
the next line. But this is an opinion, and everyone has one, and you
know what they smell like, so take it w/a grain of salt. That said, I
would vote for :
public ObjectManagerImpl(ObjectManagerConfig config,
ThreadGroup gcThreadGroup, ClientStateManager
stateManager,
ManagedObjectStore objectStore, EvictionPolicy cache,
PersistenceTransactionProvider
persistenceTransactionProvider,
Sink faultSink, Sink flushSink)
{
...
}
Taylor Gautier
Product Manager
Terracotta, Inc.
Phone: +1 (415) 738-4053
Fax: +1 (415) 738-4099
Web: www.terracottatech.com
Alex Miller wrote:
The only one of these I've actually found annoying is #2, but I can deal if majority think otherwise.
The two specific aspects of #2 I find annoying are:
a) when modifying fields that are column-aligned, I have a compulsion to manually line them up to match surrounding style (yes, I know the formatter will do this for you). I find it slightly more readable in columns but it's not always good and I find modifying that code is often harder as there are more characters to skip through.
b) Diffs are much harder to read/understand when they reformat the entire field block due to a new field or other change.
----- "Tim Eck" <[EMAIL PROTECTED]> wrote:
I guess it is okay to rehash formatting standards every couple of years, so
this is what I’m hearing:
1) The only thing that has anything close to consensus on is that we should
disable formatting for block and line comments.
2) Field alignment sounds like the people who want it disabled are passionate
about it, and those that like it the way it is can deal if we change it. Sounds
like we can give it a try
3) It seems like there are votes for each extreme on method/cstr parameters, so
I’m inclined to leave the current setting alone which is middle ground IMO.
_______________________________________________
tc-dev mailing list
[email protected]
http://lists.terracotta.org/mailman/listinfo/tc-dev
_______________________________________________
tc-dev mailing list
[email protected]
http://lists.terracotta.org/mailman/listinfo/tc-dev
