I guess I don't see anything wrong with that. It doesn't currently look like the monitor on "this" is currently being used.
It sure seems like the call to statisticsAgentSubSystem.cleanup() in DistributedObjectClient.stop():508 will throw (and log) an NPE if stop() is called before start(). Adding synch won't help that :-) > -----Original Message----- > From: [EMAIL PROTECTED] [mailto:tc-dev- > [EMAIL PROTECTED] On Behalf Of Geert Bevin > Sent: Thursday, April 03, 2008 4:51 AM > To: [email protected] > Subject: [tc-dev] Making start() and stop() of > DistributedObjectClientsynchronized > > Hi, > > I was reading through some code to figure out a JMX error that Nabib > was seeing and noticed that the DistributedObjectClient could be > stopped before the start operation was actually finished. This can put > the client into an unknown state. I was thinking of simply making both > start() and stop() synchronized, like that they can at least not > intertwine. Before I do this, can anyone see any objections, I can't > think of any. > > Take care, > > Geert > > -- > Geert Bevin > Terracotta - http://www.terracotta.org > Uwyn "Use what you need" - http://uwyn.com > RIFE Java application framework - http://rifers.org > Music and words - http://gbevin.com > _______________________________________________ > tc-dev mailing list > [email protected] > http://lists.terracotta.org/mailman/listinfo/tc-dev _______________________________________________ tc-dev mailing list [email protected] http://lists.terracotta.org/mailman/listinfo/tc-dev
