Yup, I agree with this, we should always log the exception somewhere so that it's not swallowed.
On 02 Jun 2008, at 16:42, Steven Harris wrote: > Ah, fair enough, we could have a debug log level for turning stack > traces on > for stuff that doesn't usually have them. > > On Jun 2, 2008, at 7:41 AM, Alex Miller wrote: > >> Actually, I mean even in cases beyond case a and b such as the sigar >> jira you filed. I think in that case, there is no need for a user to >> see exception but it might be helpful in debugging a problem for a >> developer to see that stack trace so they could increase log level. >> >> >> On Jun 2, 2008, at 9:37 AM, Steven Harris wrote: >> >>> That would be case a) of the a and b where the stack traces are >>> ok :-) >>> >>> On Jun 2, 2008, at 7:36 AM, Alex Miller wrote: >>> >>>> I generally agree although I think it may be useful in many cases >>>> to >>>> log the exception (for developers) at a higher (usually off) log >>>> level. >>>> >>>> >>>> On Jun 1, 2008, at 4:51 PM, Steven Harris wrote: >>>> >>>>> One area where I think their is a little bit of inconsistency in >>>>> the >>>>> Terracotta product is when to use clear error messages >>>>> and when stack traces are ok. >>>>> >>>>> I've of the opinion that any known condition should be a clear >>>>> error >>>>> message with no stack trace. The only times a stack trace should >>>>> ever be thrown are when: >>>>> a) A condition occurs where it would be useful for debugging >>>>> b) Something occurs that is completely not expected (assertion >>>>> error, >>>>> npe, etc). >>>>> >>>>> In most cases in Terracotta we do a reasonable job of this but we >>>>> still have a few niggling areas that throw stack traces that >>>>> shouldn't. >>>>> >>>>> I think we should at some point do a reasonably quick audit of the >>>>> code and clean up the rest of them. -- Geert Bevin Terracotta - http://www.terracotta.org Uwyn "Use what you need" - http://uwyn.com RIFE Java application framework - http://rifers.org Music and words - http://gbevin.com _______________________________________________ tc-dev mailing list [email protected] http://lists.terracotta.org/mailman/listinfo/tc-dev
