Hi Igal, I read through the intro, great idea to add this.
Some small suggestions: * "The functionality is injected into a specified field ..." -> I understand why you use the generic 'functionality' word here, but it reads weird. Functionality isn't injected, instances of particular types are, and those instances can provide the functionality. * "Classes that are not configured for instrumentation by Terracotta cannot be injected using this configuration." -> should be "... cannot be injected into ..." ie. they need to be configured for instrumentation so that their bytecode can be modified to perform the injection * "... it will be injected with cluster awareness." -> you don't know that since the type of the field isn't shown anywhere in the snippet. * It would be good to also gear people towards using annotations here instead of using the XML for configuring injected instances for field. Take care, Geert On 21 Apr 2009, at 01:44, Igal Levy wrote: > fixed. i've also edited that section to have a more general > introduction before focusing on cluster events. > > --------------------------------------------------- > Igal D. Levy > Terracotta Inc. > terracotta.org | terracottatech.com > 415-738-4026 > > ----- Original Message ----- > From: "Geert Bevin" <gbe...@terracottatech.com> > To: "Igal Levy" <il...@terracottatech.com> > Sent: Monday, April 20, 2009 2:53:34 AM GMT -08:00 US/Canada Pacific > Subject: Fwd: [tc-dev] Errors in cluster events documentation > > Hi Igal, > > Could you make the relevant changes? > > Thanks, > > Geert > > Begin forwarded message: > >> From: Sergio Bossa <sergio.bo...@gmail.com> >> Date: Mon 20 Apr 2009 11:51:40 GMT+02:00 >> To: tc-dev <tc-dev@lists.terracotta.org> >> Subject: [tc-dev] Errors in cluster events documentation >> Reply-To: tc-dev@lists.terracotta.org >> >> Hi guys, >> >> the cluster events documentation at >> "http://terracotta.org/web/display/docs/Configuration+Guide+and+Reference#ConfigurationGuideandReference-injectedinstances >> " >> has the following errors: >> >> - The "/tc:tc-config/clients/dso/injected-instances" path is wrong, >> it >> should be: "/tc:tc-config/application/dso/injected-instances" >> - The related XML snippet, reported as an example, doesn't actually >> contain the field name, but just the class name: >> "<field-name>com.mypackage.myClasses.OtherClusterAwareClass</field- >> name>" >> >> Cheers, >> >> Sergio B. >> >> -- >> Sergio Bossa >> Software Passionate and Open Source Enthusiast. >> Blog : http://sbtourist.blogspot.com >> Pro-Netics : http://www.pronetics.it >> Sourcesense : http://www.sourcesense.com >> _______________________________________________ >> tc-dev mailing list >> tc-dev@lists.terracotta.org >> http://lists.terracotta.org/mailman/listinfo/tc-dev > > -- > Geert Bevin > Terracotta - http://www.terracotta.org > Uwyn "Use what you need" - http://uwyn.com > RIFE Java application framework - http://rifers.org > Flytecase Band - http://flytecase.be > Music and words - http://gbevin.com > -- Geert Bevin Terracotta - http://www.terracotta.org Uwyn "Use what you need" - http://uwyn.com RIFE Java application framework - http://rifers.org Flytecase Band - http://flytecase.be Music and words - http://gbevin.com _______________________________________________ tc-dev mailing list tc-dev@lists.terracotta.org http://lists.terracotta.org/mailman/listinfo/tc-dev
