I'm making this change, needed some refactoring and restructuring to the async 
classes, final test suite run to make sure it's all ok still.

On 03 Jun 2010, at 21:46, Tim Eck wrote:

> Yeah from your description that sounds off and mutable classes are so
> yucky to begin with
> 
>> -----Original Message-----
>> From: tc-dev-boun...@lists.terracotta.org [mailto:tc-dev-
>> boun...@lists.terracotta.org] On Behalf Of Chris Dennis
>> Sent: Thursday, June 03, 2010 11:51 AM
>> To: tc-dev
>> Subject: [tc-dev] Synchronous write nature of TerracottaReadWriteLock
>> (was SharedReadWriteLock)
>> 
>> Hi All,
>> 
>> From what I can see the the synchronous write property of the
>> TerracottaReadWriteLocks is never mutated during the object lifetime
>> in any of its current usages.  What's more changing this property when
>> the lock is locked is a really bad idea.  (It will lead to threads
>> throwing IllegalMonitorStateException during unlock).  With this in
>> mind I think it would make sense to move this property to being a
>> constructor parameter.
>> 
>> Thoughts?
>> 
>> Chris
>> 
>> _______________________________________________
>> tc-dev mailing list
>> tc-dev@lists.terracotta.org
>> http://lists.terracotta.org/mailman/listinfo/tc-dev
> _______________________________________________
> tc-dev mailing list
> tc-dev@lists.terracotta.org
> http://lists.terracotta.org/mailman/listinfo/tc-dev

--
Geert Bevin
Terracotta - http://www.terracotta.org

_______________________________________________
tc-dev mailing list
tc-dev@lists.terracotta.org
http://lists.terracotta.org/mailman/listinfo/tc-dev

Reply via email to