Guy Harris wrote:
On Feb 13, 2008, at 6:14 PM, sagun shakya wrote:
Updated webrev can be found at:
http://cr.opensolaris.org/~sagun/libpcap-review2/
Why did you add a
AC_CHECK_HEADERS(sys/bufmod.h)
check to configure.in after the check for libdlpi? It's checked for
later in the case statement if V_PCAP is dlpi or, in your version,
libdlpi.
In my version, beside the check in line 236 the check is only in the
case statement 'if V_PCAP is dlpi' (line 360).
This check could be moved to line 295 i.e the check if $V_PCAP is
dlpi|libdlpi.
-Thanks,
Sagun
-
This is the tcpdump-workers list.
Visit https://cod.sandelman.ca/ to unsubscribe.
