On Mon, Mar 26, 2018 at 11:09:03AM -0700, Guy Harris wrote:
> > 0004-Add-Wdocumentation-to-development-warnings.patch
> > 
> > Patch 4 is kind of "unclean" as it still generates warnings in the 
> > generated file
> > scanner.c on my system (current macos with current xcode).
> 
> Is that due to problems with what's in scanner.l or due to problems in the 
> code that Flex generates?
> 
> If it's the latter, add "diagnostic ignored "-Wdiagnostic"" items to 
> DIAG_OFF_FLEX for the compilers that support it.

There is no doxygen code in scanner.l. I followed your advice above and the 
attached patch fixes the problem.

Thanks!
   Jörg

-- 
Joerg Mayer                                           <jma...@loplof.de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
>From 8551f6f318fae4e305de1c119b9600f065fa8def Mon Sep 17 00:00:00 2001
From: Joerg Mayer <jma...@loplof.de>
Date: Tue, 27 Mar 2018 12:46:29 +0200
Subject: [PATCH 3/3] Turn off -Wdocumentation warning for generated files
 generated by flex 2.5.35 Apple(flex-31)

Signed-off-by: Joerg Mayer <jma...@loplof.de>
---
 diag-control.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/diag-control.h b/diag-control.h
index 8ab89526..2b51269f 100644
--- a/diag-control.h
+++ b/diag-control.h
@@ -70,6 +70,7 @@
     #define DIAG_OFF_FLEX \
       PCAP_DO_PRAGMA(clang diagnostic push) \
       PCAP_DO_PRAGMA(clang diagnostic ignored "-Wsign-compare")
+      PCAP_DO_PRAGMA(clang diagnostic ignored "-Wdocumentation")
     #define DIAG_ON_FLEX \
       PCAP_DO_PRAGMA(clang diagnostic pop)
   #elif PCAP_IS_AT_LEAST_GNUC_VERSION(4,6)
-- 
2.14.3 (Apple Git-98)

_______________________________________________
tcpdump-workers mailing list
tcpdump-workers@lists.tcpdump.org
https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers

Reply via email to