On 1/20/2019 11:52 AM, Andrew Lunn wrote: > On Fri, Jan 18, 2019 at 10:19:04AM -0800, Florian Fainelli wrote: >> On 1/18/19 6:13 AM, Michael Richardson wrote: >>> >>> Guy Harris <ghar...@sonic.net> wrote: >>> >> OK, then requesting 10 DLT values, one per-tag is reasonable? >>> >>> > Yes. >>> >>> This is totally how it should be done. >>> >>> Guy, do we want to allocate 16 or 32 values, aligned, so that the >>> it be can DLT_TAG_BASE + DSA_TAG_xx maps? Are the kernel values stable? >>> And to leave room for growth. >> >> The kernel values are stable because they are now (as of 4.19) part of >> the sysfs attribute ABI. Having a base to offset from would ne neat. > > Hi Florian > > As Guy points out, we should probably move them into a uapi > header. That makes it clear the values are ABI. UAPI is probably a bit too much, but I can certainly extend the attribute documented here for the supported values:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/ABI/testing/sysfs-class-net-dsa -- Florian _______________________________________________ tcpdump-workers mailing list tcpdump-workers@lists.tcpdump.org https://lists.sandelman.ca/mailman/listinfo/tcpdump-workers
