On Tue, Oct 02, 2001 at 03:47:52PM +0900, Motonori Shindo wrote: > I don't see any reason why this many header files need to be > #include-ed, first of all.
I agree - I looked at the code, and it's not doing any protocol operations. > I also noticed that this file has DOS line > style (terminated by CR/LF). Those shouldn't be there either. (Windows compilers can probably live without them, and I suspect most Windows programmer's editors can do so as well; Ethereal manages to survive as a Windows application, as well as a UNIX application, without CR/LF at the ends of lines.) > Here's a patch to fix these. I checked in my own change to get rid of most of the #includes, and the CRs, before I saw your mail; I've subsequently checked in a change that removes most of the ones I hadn't removed but you had removed, but I left the #include of "interface.h" in, so that "dump_and_trunc()" is declared before it's defined (so that if the definition is changed and no longer matches the declaration, it won't compile, obliging you to change the declaration - and thus obliging you to change the places where it's used). - This is the TCPDUMP workers list. It is archived at http://www.tcpdump.org/lists/workers/index.html To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe
