On Wed, Nov 21, 2001 at 11:54:16AM +0100, Heinz-Ado Arnolds wrote:
> I have done some changes to tcpdump-3.6.2 mainly to print IPX packets
> more verbose than in the original distribution. The changes are:
> 
>  - created a new hash table for the names of IPX service types
>    (ipxsaptable[]) loaded from ipxsap_db[] and initialized by
>    init_ipxsaparray() in addrtoname.c
>  - print the names for service numbers in IPX packets in print-ipx.c
>    (function ipxsap_string())
>  - print the Novell names of protocols of IPX packets ("(NOV-ETHII) ",
>    "(NOV-802.3) ", "(NOV-802.2) ") in print-ether.c and print-llc.c
>  - show the service(port) number in IPX packets with 4 digits fixed
>    (adjusted format strings in print-ipx.c)
>  - show the net in IPX packets with 8 digits fixed
>    (adjusted format string in print-ipx.c)
>  - mark 802.3 MAC headers ("802.3: ") in print-ether.c

I've put

         - created a new hash table for the names of IPX service types
           (ipxsaptable[]) loaded from ipxsap_db[] and initialized by
           init_ipxsaparray() in addrtoname.c
         - print the names for service numbers in IPX packets in print-ipx.c
           (function ipxsap_string())
         - show the service(port) number in IPX packets with 4 digits fixed
           (adjusted format strings in print-ipx.c)
         - show the net in IPX packets with 8 digits fixed
           (adjusted format string in print-ipx.c)

into the current CVS code, with some changes.

The

         - print the Novell names of protocols of IPX packets ("(NOV-ETHII) ",
           "(NOV-802.3) ", "(NOV-802.2) ") in print-ether.c and print-llc.c

seems reasonable, for IPX packets; I'll look at that one as well.

I'm not sure whether we'd want to do

         - mark 802.3 MAC headers ("802.3: ") in print-ether.c

though.  Is there a need to distinguish between 802.3 and D/I/X Ethernet
packets in that case, as per

> diff -ur tcpdump-3.6.2.orig/print-ether.c tcpdump-3.6.2/print-ether.c
> --- tcpdump-3.6.2.orig/print-ether.c  Fri Dec 22 23:45:10 2000
> +++ tcpdump-3.6.2/print-ether.c       Wed Nov 21 10:20:07 2001
> @@ -112,6 +112,7 @@
>        */
>       extracted_ethertype = 0;
>       if (ether_type <= ETHERMTU) {
> +             printf("802.3: ");
>               /* Try to print the LLC-layer header & higher layers */
>               if (llc_print(p, length, caplen, ESRC(ep), EDST(ep),
>                   &extracted_ethertype) == 0) {

printing "802.3:" before the LLC header?  Or is it sufficient to see the
LLC header?
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe

Reply via email to