>-------------------------------
>Description:
>correct address pair printing on truncated case.
>Modified files:
> File: tcpdump/print-udp.c; Revision: 1.102;
> Date: 2001/11/26 06:48:12; Author: itojun; Lines: (+52 -66)
>=====================================================
>
>Doesn't this print "0 > 0" on the truncated case? I think you need
>3 cases; IP address and port, IP address only, and port only.
we only need two cases (IP address and port, IP address only) here.
>I'd also note that 0 is not outside of the range that can be observed
>on the wire for port numbers. It would be much better to use a value
>outside the range, e.g. -1 in an int argument.
"udp destination port number 0" is outside of the spec, it is
not allowed. so i've used that to indicate "no port number".
i think you right.
itojun
-
This is the TCPDUMP workers list. It is archived at
http://www.tcpdump.org/lists/workers/index.html
To unsubscribe use mailto:[EMAIL PROTECTED]?body=unsubscribe
