Bill,
From: Bill Fenner <[EMAIL PROTECTED]>
Subject: Re: GRE patch
Date: Mon, 12 Mar 2001 17:07:18 -0800
Message-ID: <[EMAIL PROTECTED]>
>
> BTW, the offset and checksum handling in this patch was broken; it treated
> them as two seperate 4-byte fields but they're each 2-byte fields which
> are both present when either one is present.
Oops, this was my fault. Sorry. Please apply this patch.
> I don't see a real reason to print the checksum. Checking it like the
> TCP and UDP printers do might make sense, but just printing it doesn't
> seem useful to me.
Agreed. I will work on it. Thanks.
=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=
+----+----+
|.. .| | Motonori Shindo
|_~__| |
| .. |~~_~| Sr. Systems Engineer
| . | | CoSine Communications Inc.
+----+----+
C o S i n e e-mail: [EMAIL PROTECTED]
Communications
=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=--=
? print-atmp.c
Index: print-gre.c
===================================================================
RCS file: /tcpdump/master/tcpdump/print-gre.c,v
retrieving revision 1.11
diff -c -r1.11 print-gre.c
*** print-gre.c 2001/03/12 00:24:55 1.11
--- print-gre.c 2001/03/13 04:26:21
***************
*** 116,128 ****
if (flags & GRE_CP) {
TCHECK2(*cp, 4);
if (vflag > 1)
! printf("C:%08x ", EXTRACT_32BITS(cp));
cp += 4; /* skip checksum */
}
if (flags & GRE_OP) {
TCHECK2(*cp, 4);
if (vflag > 1)
! printf("O:%08x ", EXTRACT_32BITS(cp));
cp += 4; /* skip offset */
}
if (flags & GRE_KP) {
--- 116,128 ----
if (flags & GRE_CP) {
TCHECK2(*cp, 4);
if (vflag > 1)
! printf("C:%04x ", EXTRACT_16BITS(cp));
cp += 4; /* skip checksum */
}
if (flags & GRE_OP) {
TCHECK2(*cp, 4);
if (vflag > 1)
! printf("O:%04x ", EXTRACT_16BITS(cp));
cp += 4; /* skip offset */
}
if (flags & GRE_KP) {
