On Mon, Apr 14, 2014 at 02:21:27PM -0400, Ted Unangst wrote:
> On Mon, Apr 14, 2014 at 20:09, Otto Moerbeek wrote:
> >> > static int
> >> > -insert(struct dir_info *d, void *p, size_t sz, void *f)
> >> > +insert(struct dir_info *d, void *p, uintptr_t sz, void *f)
> >>
> >> Doesn't it make sense for sz to stay a size_t in this case? it appears
> >> to still be used as an offset in here, not a pointer. no?
> >
> > Indeed, I don't see why you would change the type of the parameter here.
>
> That is what the caller (with a chunk_info *) is casting it to.
there are two other calls with a size_t arg, and inside insert() the
arg is directly stuffed into a field of the union which is size_t.
-Otto
