On Sat, 15 May 2021, Jason McIntyre wrote:

> hi.
> 
> so i'm ok with this. two more points:
> 
> - i'd use a colon after "15%", not a full stop
> - i'd remove the " check the man page" line and .Pp because it'd save space 
> and we already Xr the page. up to you though.

Those make sense (diff at the end with corrections).
I'll commit it later if nobody objects.

Thank you Jason.

> 
> jmc
> 
> On 15 May 2021 17:14:55 BST, Paco Esteban <[email protected]> wrote:
> >Hi Jason,
> >
> >On Sat, 15 May 2021, Jason McIntyre wrote:
> >
> >> On Sat, May 15, 2021 at 12:27:53PM +0200, Paco Esteban wrote:
> >> > Hi,
> >> > 
> >> > This adds a mention to apmd(8) on afterboot(8).  Original idea is
> >from
> >> > kmos@, crappy wording is mine (corrections/suggestions welcome).
> >> > 
> >> > ok to commit ?
> >> > 
> >> 
> >> hi.
> >> 
> >> i guess i don;t object, but i'm not convinced this page needs such a
> >> large block of text on power management. there is a "Daemons" section
> >> which could just provide a nod to the relevant pages.
> >
> >I put it there after the Video stuff which is somewhat tailored to
> >laptop users.  But I don't have a strong opinion on where to put it.
> >
> >The Daemons section only mentions intro(8) which does not have any
> >mention of apmd(8) at all.
> >
> >As we already make mentions to things like Printers or Video there it
> >does not feel weird to me.  But yeah, it could be shorter.  Maybe
> >without the rcctl example lines and just point to the man page.
> >
> >In any case, mods below with your suggestions.
> >
> >> 
> >> one note inline:
> >> 
> >> > diff b8464fd1ac0e783621fb415f7922223b0d73c4fb /usr/src
> >> > blob - 8b4079f857da2aa79783848d450addba1e5831e6
> >> > file + share/man/man8/afterboot.8
> >> > --- share/man/man8/afterboot.8
> >> > +++ share/man/man8/afterboot.8
> >> > @@ -418,6 +418,23 @@ Normal recording can be enabled by adding the
> >followin
> >> >  kern.audio.record=1
> >> >  kern.video.record=1
> >> >  .Ed
> >> > +.Ss Power management
> >> > +The
> >> > +.Xr apmd 8
> >> > +daemon controls the Advanced Power Management (APM).
> >> > +If your device's BIOS supports it, you can configure this daemon
> >to act on
> >> > +different events and adjust the performance of your device.
> >> 
> >> we tend to avoid 2nd person text like this. so it could be written
> >like:
> >> 
> >>    If the BIOS supports it, the daemon can be configured to act on
> >>    different events and adjust device performance.
> >
> >Right, that reads way better.
> >I've included a modified version at the end with that form and a wee
> >bit
> >shorter.
> >
> >> 
> >> jmc
> >> 
> >> > +In the following example
> >> > +.Xr apmd 8
> >> > +is configured to start on boot in automatic performance adjustment
> >mode and
> >> > +suspend the system if no AC is connected and the estimated battery
> >life is
> >> > +equal or below 15%.
> >> > +.Bd -literal -offset indent
> >> > +# rcctl set apmd status on
> >> > +# rcctl set apmd flags -A -z 15
> >> > +.Ed
> >> > +.Pp
> >> > +For more information check the man page.
> >> >  .Ss Mail aliases
> >> >  Edit
> >> >  .Pa /etc/mail/aliases
> >
> >diff aeddc3fc1c2dc619781d7d37222447f40fb248a7 /usr/src
> >blob - 8b4079f857da2aa79783848d450addba1e5831e6
> >file + share/man/man8/afterboot.8
> >--- share/man/man8/afterboot.8
> >+++ share/man/man8/afterboot.8
> >@@ -418,6 +418,19 @@ Normal recording can be enabled by adding the
> >followin
> > kern.audio.record=1
> > kern.video.record=1
> > .Ed
> >+.Ss Power management
> >+If the BIOS supports it,
> >+.Xr apmd 8
> >+can be configured to act on different events and adjust device
> >performance.
> >+In the following example it is configured to start on boot in
> >automatic
> >+performance adjustment mode and suspend the system if no AC is
> >connected and
> >+the estimated battery life is equal or below 15%.
> >+.Bd -literal -offset indent
> >+# rcctl set apmd status on
> >+# rcctl set apmd flags -A -z 15
> >+.Ed
> >+.Pp
> >+For more information check the man page.
> > .Ss Mail aliases
> > Edit
> > .Pa /etc/mail/aliases
> 

diff refs/heads/master refs/heads/mystuff
blob - 8b4079f857da2aa79783848d450addba1e5831e6
blob + 06f70e3860849c899682c2e23d42f1a21fcd9bf4
--- share/man/man8/afterboot.8
+++ share/man/man8/afterboot.8
@@ -418,6 +418,17 @@ Normal recording can be enabled by adding the followin
 kern.audio.record=1
 kern.video.record=1
 .Ed
+.Ss Power management
+If the BIOS supports it,
+.Xr apmd 8
+can be configured to act on different events and adjust device performance.
+In the following example it is configured to start on boot in automatic
+performance adjustment mode and suspend the system if no AC is connected and
+the estimated battery life is equal or below 15%:
+.Bd -literal -offset indent
+# rcctl set apmd status on
+# rcctl set apmd flags -A -z 15
+.Ed
 .Ss Mail aliases
 Edit
 .Pa /etc/mail/aliases

-- 
Paco Esteban.
0x5818130B8A6DBC03

Reply via email to