On Thu, 15 Dec 2022 18:16:11 +0100, Theo Buehler wrote: > This should probably been part of my last diff, but I noticed it only > on commit... acme-client contains the same mistake as rpki-client had: > all times in certificates are expressed in GMT, so using the TZ dependent > output of mktime() and mixing it with the output of time(NULL) is wrong. > > I don't think it matters all that much here that we might be off by half > a day compared to the 30 days RENEW_ALLOW, but it's still wrong.
Using timegm() looks like the right thing to use (and it is finally getting standardized in C23). OK millert@ - todd
