On Mon, Apr 19, 2010 at 05:26:03PM +0200, Martin Husemann wrote: > On Mon, Apr 19, 2010 at 04:22:29PM +0100, Mindaugas Rasiukevicius wrote: > > Right, except callout_schedule() should be enough. Also, you have removed > > callout_stop() from syn_cache_rm(). In such case it is unsafe, you need > > to keep it. > > s/callout_stop()/callout_halt()/ ?
No, callout_halt() would need to drop the softnet_lock. This is the problem, and also why we need to defer freeing the syn cache entries. -- Manuel Bouyer <bou...@antioche.eu.org> NetBSD: 26 ans d'experience feront toujours la difference --