On Sat, Jul 17, 2010 at 05:29:19AM -0700, Paul Goyette wrote: > On Sat, 17 Jul 2010, David Young wrote: > >3 Watchdog prevents suspension > > As I indicated, this is fairly easy to do, simply check if the w-dog > is armed or not. > > The attached patch provides an ipmi_suspend() method to implement > #3. But I suspect that this is really a more generic watchdog > capability, and it should be implemented for the entire class of > watchdogs rather than only for ipmi(4)?
It is a generic capability. ISTM watchdog timers should eventually be refactored in this way: each watchdog timer in the system should have a corresponding pseudo-device, an instance of wdog(4). wdog(4) provides its own suspension/resumption/detachment routines. Let wdog_suspend() return false if the watchdog is active (for now). ipmi0 should attach wdog0 using a wdogbus interface attribute. Let struct sysmon_wdog become the watchdog attachment arguments, wdog_attach_args. Your patch looks fine. Dave -- David Young OJC Technologies dyo...@ojctech.com Urbana, IL * (217) 278-3933