Hi! Matthias,
From: Matthias Drochner <[email protected]> Date: Sat, 11 Sep 2010 13:28:32 +0200 > > [email protected] said: > > + if (sc->sc_flags & EHCIF_HAVE_TT) > > [...] > > +#define EHCI_PS_PSPD_HS 0x08000000 /* High speed */ > > The way this is put into the "ehci" namespage suggests that > there is only a single blessed way to have a Transaction > Translator as an integral part of an EHCI. In the spec I know, > these bits are "reserved". > Are these extensions somehow on a standards track? If not, > I suggest to use a naming which makes clear that this is > just a vendor extension. Or better, add only hooks to > ehci.c and put the code into a new attachment frontend. No, I track not standards. > > +#define EHCI_PS_PSPD_HS 0x08000000 /* High speed */ Is better name EHCI_VENDOR_EXT_PS_PSPD_HS? Do we create new file named ehci_vext.c? Thanks, -- kiyohara
