> On Tue, Jan 18, 2011 at 11:22:33AM +0100, Christoph Egger wrote: > > > > > i like this look of this much better than prior patches. thanks > > > for doing this properly. > > > > > > i just have one minor suggestion. i don't see the point in the > > > two new files with one function proto and a 5 line function. can > > > you please move them into wsdisplay.c and wsdisplayvar.h? thanks. > > > > The reason is that the new function adds dependencies to the > > different busses. Currently only for PCI. But other busses > > may be added in future. > > > > Moving that function into wsdisplay.c will add bus dependencies > > to wsdisplay.c. > > I think I agree with Christoph here: if he avoids sprinkling wsdisplay.c > with bus-related #ifdefs by adding new files, he should definitely do > that.
that's a good idea. since it's PCI specific, perhaps sys/dev/pci/wsdisplay_pci.c is a better place? .mrg.
