On 04/06/11 13:44, Vladimir Kirillov wrote:
Hello, tech-kern@!Here's the diff for ddb(4): - reuse the common code for stack traces (and rely on sizeof(long) in most cases) - use db_read_* api to be usable from crash(8). I need this for crash(8) amd64 support diff which I'll send in the next letter. I'm using this on amd64, survived a kernel build on i386, tests are welcome!
Some inline comments:
@@ -656,7 +657,7 @@ age* at pci? dev ? function ? # Attansic alc* at pci? dev ? function ? # Attansic/Atheros L1C/L2C Ethernet ale* at pci? dev ? function ? # Attansic/Atheros L1E Ethernet an* at pci? dev ? function ? # Aironet PC4500/PC4800 (802.11) -ath* at pci? dev ? function ? # Atheros 5210/5211/5212 802.11 +#ath* at pci? dev ? function ? # Atheros 5210/5211/5212 802.11 atw* at pci? dev ? function ? # ADMtek ADM8211 (802.11) bce* at pci? dev ? function ? # Broadcom 440x 10/100 Ethernet bge* at pci? dev ? function ? # Broadcom 570x gigabit Ethernet
Why?
@@ -730,7 +731,7 @@ com* at mhzc? sm* at mhzc? # CardBus network cards -ath* at cardbus? function ? # Atheros 5210/5211/5212 802.11 +#ath* at cardbus? function ? # Atheros 5210/5211/5212 802.11 atw* at cardbus? function ? # ADMtek ADM8211 (802.11) ex* at cardbus? function ? # 3Com 3C575TX fxp* at cardbus? function ? # Intel i8255x
Why?
