On Tue, Oct 23, 2012 at 01:12:29PM +0200, iMil wrote:
>
> >Mostly says that our driver doesn't talk "correctly" to the hardware.
> >The panic in this place is of course pretty silly.
> >
> > if (hb == sc->heartbeat)
> > panic("ciss: dead"); /* XX reset! */
> >
> >Linux just ignores the heartbeat counter. I'd replace the panic with
> >a possibly ratechecked printf() and try if that works.
>
> It works. The controller is now seen and working, I'm not really familiar
> with those drivers, is this check bypass safe? May I fill a PR with
> this "fix"?
Yes, please open a PR.
--
Michael van Elst
Internet: [email protected]
"A potential Snark may lurk in every tree."