Date: Sun, 11 Nov 2012 05:55:23 +0100 From: m...@netbsd.org (Emmanuel Dreyfus)
Taylor R Campbell <campbell+netbsd-tech-k...@mumble.net> wrote: > + /* > + * openat() falls back to open() behavior if > + * - path is absolute XXX check this. > + * - fd is AT_FDCWD > + */ > > Have you checked the XXX, and/or written automatic tests for it? In order to check for absolute path, I need to copyin the path, and it wil be copied in later again. I suspect that check should go at namei level. Sorry, my question wasn't clear. All I meant was `Have you confirmed by code inspection that this is true, and/or written some atf tests to verify it automatically?'.