On 15 Apr 2014, at 18:11, Taylor R Campbell <campbell+netbsd-tech-k...@mumble.net> wrote:
> Date: Mon, 14 Apr 2014 15:58:28 +0200 > From: "J. Hannken-Illjes" <hann...@eis.cs.tu-bs.de> > > Also replaced the cv_wait/cv_broadcast with kpause as insert collisions > are very rare and moved the common vnode initialisation to vnalloc. > > New diff at http://www.netbsd.org/~hannken/vnode-pass6-3.diff > > Plan to commit early wednesday ... > > I still don't think this approach is right. It makes a long-term copy > of logic in getnewvnode (because this vcache(9) will not be applicable > everywhere), there's no reason to use kpause or any new condvars when > we already have one inside each vnode which we'll be using anyway in > vget, and it still increases the overhead of every vnode using it. > > I don't object to the principle of VFS_LOAD_NODE, or VOP_LOAD, but at > the moment I think it will cause greater divergence between file > systems and maintenance headaches as a result. Still don't see the divergence and maintenance headaches. This discussion is bogged down. If no new arguments come up we should ask core@ for a decision. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
