Hi,

From: David Holland <dholland-t...@netbsd.org>, Date: Sun, 12 Jul 2015 17:39:55 
+0000

> On Sun, Jul 12, 2015 at 03:13:56PM +0100, Mindaugas Rasiukevicius wrote:
>  > > +#if !defined(BITS_PER_LONG)
>  > > +#define BITS_PER_LONG __SIZEOF_LONG__*8
>  > > +#endif
>  > 
>  > I did not look how exactly is this used, but it is a good idea to use
>  > brackets around the expression when dealing with macros.  Just prevents
>  > from any future bugs.
> 
> Also, that should be CHAR_BIT and not a magic 8...

Thank you.
I will use CHAR_BIT.

> -- 
> David A. Holland
> dholl...@netbsd.org

--
Ryo ONODERA // ryo...@yk.rim.or.jp
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

Reply via email to