os...@cs.usask.ca (Greg Oster) writes:

>Have these changes, especially those to raiddump(), been extensively
>tested?
 
The regular operation has been tested extensively, in particular with
different component drivers and the autoconfig,  but raiddump() not. 

> RF_PROTECTED_SECTORS used to be required in raiddump() so as
>not to eat the component label.

Thanks for noticing, I have fixed that now together with another
problem that made all dumps fail.

> raid_dumpblocks() now contains what
>raiddump() used to, but it raiddump() has to be able to
>select which of the underlying components is still alive, and not to
>attempt to dump to anything other than a RAID 1 device.

The checks are still made in raid_dumpblocks() (and therefore repeated
for every page dumped, but that is a different issue).

-- 
-- 
                                Michael van Elst
Internet: mlel...@serpens.de
                                "A potential Snark may lurk in every tree."

Reply via email to