Date: Tue, 5 Jan 2016 09:39:15 +0800 (PHT) From: Paul Goyette <p...@whooppee.com>
On Tue, 5 Jan 2016, Taylor R Campbell wrote: > So I think DIAGNOSTIC condition is wrong. I think the right condition > is probably uio->uio_vmspace == vmspace_kernel(). Yes, this make a lot of sense. I will fix it in both spec_write() and in spec_read(). I glanced at some other callers, and it looks like the usual idiom is VMSPACE_IS_KERNEL_P(uio->uio_vmspace). (This actually checks whether the vmspace's vm_map's pmap is pmap_kernel(), although I'm not sure there are going to be any other vmspaces than vmspace_kernel() for which that is true.)