> Date: Mon, 11 Dec 2017 11:55:27 +0100 > From: Edgar Fuß <[email protected]> > > > struct psref { > > - LIST_ENTRY(psref) psref_entry; > > + SLIST_ENTRY(psref) psref_entry; > > + /* To keep ABI with LIST_ENTRY(psref) version. */ > > + void *psref_unused0; > Isn't it somewhat fishy to manally pad this, knowing how big a [S]LIST_ENTRY > is? Wouldn't it be cleaner to use a union?
Also fine by me, but a little more work to implement. Feel free to add some ctasserts to raise your confidence in this. I don't expect LIST_ENTRY or SLIST_ENTRY to change, but I don't mind assertions to add additional confidence.
