In article <CAKrYomiYk93wa12jrbr6Yw5BkJ60fcU1BVJj=_ommC=gb5w...@mail.gmail.com>, Ryota Ozaki <[email protected]> wrote: >Hi, > >For a certain reason(*), DAD timers are hard to use >callout_halt to destroy DAD timer objects. So I was going >to fall back to callout_stop (as of NetBSD 7) that is >almost safe but still has a possibility of going wrong(**). > >(*) See the thread starting at >http://mail-index.netbsd.org/source-changes-d/2017/12/26/msg009744.html >(**) http://mail-index.netbsd.org/source-changes-d/2018/01/11/msg009802.html > >Discussing with @riastradh, we found a possible way to >make DAD timer destructions MP-safe with callout_stop. >This is a PoC patch: > http://www.netbsd.org/~ozaki-r/dad-callout_stop.v2.diff > >The issue of using callout_stop instead of callout_halt is >that callout_stop doesn't actually stop the running callout. >So we cannot safety free a related data after calling >callout_stop. > >The new approach copes with the issue by delegating the >destruction of a callout to callout itself, which allows us >to not wait the callout to finish. This can be done thanks >to that DAD objects are separated from other data such as >ifa.
Even then (with callout_halt) nothing prevents something from calling callout_schedule() or callout_reset() again between that time and callout_destroy()... I have code that adds another flag that stops further callouts from being reschuled. Does this help you? christos
