At Sun, 17 Feb 2019 08:48:01 +0100, Martin Husemann wrote: > > I wrote atf tests for atomic_ops(3). > > These does not test the atomicity but can find a easy bug. > > Is this ok to commit? > > (I know there is a similar path tests/lib/libc/sync but > > I think it's better to not merge) > > Why not? > > Or we could remove all ops from tests/lib/libc/sync that are covered in this > tests, and if that test covers all, remove tests/lib/libc/sync completly. > > The rationaly for tests/lib/libc/sync was just to spot missing symbols, if > we even test the function, that is obviously better.
Ah, that makes my understanding clear. Well then, I add atomic_ops part this time. And I will prepare sync_* tests and add them in tests/lib/libc/atomic (in order to replace tests/lib/libc/sync). Thanks, --- Tetsuya Isaki <[email protected] / [email protected]>
