Hi,

First of all, I'm sorry for not replying for this long.  I've got
distracted with other things, and I've completely forgotten about this.

On Tue, 2019-07-16 at 05:23 +1000, matthew green wrote:
> > Introduce a simple COREDUMP_MACHDEP_LWP_NOTES logic to provide machdep
> > API for injecting per-LWP notes into coredumps, and use it to append
> > PT_GETXSTATE note.
> 
> this macro is pretty gross.  these are the problems i see:
> 
> - assumes 'int error'

This goes away if we're removing error handling.

> - assumes 'struct lwp *l = curlwp'
> - assumes 'name' is something
> - assumes 'ns' is something

Made into parameters.

> - returns from macro

Resolved as you suggested -- we're silently skipping this entry if it
fails.

I'm going to resend the whole series as v4 now.

-- 
Best regards,
Michał Górny

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to