On Thu, 28 Dec 2023 14:51:35 +0100 Tobias Nygren <t...@netbsd.org> wrote:
> On Thu, 28 Dec 2023 00:19:44 +0000 > Taylor R Campbell <campbell+netbsd-tech-k...@mumble.net> wrote: > > > > +#ifdef _LP64 > > > + if (eaddr < (1UL<<40)) { > > > Just to confirm: eaddr is inclusive here, right? As in, if the range > > were [0x10000, 0x20000), we would have saddr=0x10000 eaddr=0x1ffff (or > > maybe eaddr=0x1f000), right? > > The end boundary is page-aligned non-inclusive. Thus strict less-than > is correct. I'll change to ((paddr_t)1 << 40) for clarity. Brain fart. It should be <= of course.