In article <21451069.kys5rkk...@uberpc.marples.name>,
Roy Marples  <r...@marples.name> wrote:
>On Sunday 20 March 2016 23:05:12 Christos Zoulas wrote:
>> In article <1547312.w6y7ml9...@uberpc.marples.name>,
>> Roy Marples  <r...@marples.name> wrote:
>> 
>> There is no need for pidfile_lock(), just fix pid_file() to return pid_t.
>> I've audited the code in the tree and the code that checks, checks for -1.
>> The compat code below is probably wrong anyway.
>
>Ah, but it needs to check for != 0 as it can return the pid who has the lock, 
>which is itself an error.

Ok... I guess pidfile_lock it is.

christos

Reply via email to