On Tue, Oct 10, 2006 at 05:57:33PM +0200, bbackde at googlemail.com wrote: > Frost uploads DO work if they take not longer than the timeout that frost > uses. > > Where was the thing with the mandatory filename dicussed? Imho this is > a very bad idea! Files with exactly same content but different names > get different keys?
On tech. Nobody cared about it at the time, as usual. It's not "mandatory"; you can insert it with no filename if you want to, but then you can't add it on later. > > Then Frost will need to do some bad things to work around this. Frost > uses the SHA of a file to uniquely identify it, and it expects that > the CHK key is the same for the same file. This only works if your CHK is a simple CHK. Fred has the opposite problem because it has to deal with larger keys e.g. with manifest lookups. And it can't just compare them, because you can add arbitrary strings to the end of a key (after a /) and it will still work, at present. Which is counterintuitive and makes it hard to compare keys. > > On 10/10/06, toad <toad at amphibian.dyndns.org> wrote: > >On Tue, Oct 10, 2006 at 05:08:25PM +0200, bbackde at googlemail.com wrote: > >> The node accepts TargetFilename= and I will fix Frost. The point is > >> that until I release a new Frost (which is always not such easy as > >> e.g. for Thaw) Frost will not work any longer for CHK uploads. > > > >I wasn't aware that Frost uploads *did* work... > >> > >> I don't know why the node now fails with a simple CHK@ put without > >> TargetFilename=. > > > >Good question. File a bug. I will investigate when I get back. > > > >> There is never a key returned. This prevents the currently used Frost > >> from any CHK upload, because you "fixed" the node! Bad. > >> > >> So you mean I could fix the node so if no TargetFilename= is given it > >> assumed there is one? > > > >Oh, so your first bug report was superseded by the second? Ahh, okay. > > > >Well, you could turn off auto-detection from the filename; but generally > >it seemed like a good idea to me... I dunno, if you want to temporarily > >comment it out (only the detection from the upload-from filename) to make > >Frost work until the new version comes out, you have my permission to do > >so. > > > >Further, PLEASE BEAR THE FOLLOWING IN MIND: > > > >In the future, it will no longer be possible to insert CHK at blah,blah and > >then append an arbitrary filename to it afterwards. The filename must be > >provided on insertion, and will be required in order to download the > >file. The advantage of this is that it simplifies comparing keys (which > >is good for e.g. client cache), and it makes keys behave more like real > >URLs; you can't add /blah/blah/blah/blah on to a URL and expect it to > >still work. > > > >So if you are going to add a filename to the end of the CHK, you need to > >specify it when you insert it. > >> > >> On 10/10/06, toad <toad at amphibian.dyndns.org> wrote: > >> >Yes, you may need to fix this yourself. Please don't remove the > >> >auto-detection though; the correct fix is to: > >> >1) Make Frost set TargetFilename= > >> >and 2) Fix the node if the node is failing with TargetFilename= > >> > > >> >On Tue, Oct 10, 2006 at 02:12:04PM +0200, bbackde at googlemail.com wrote: > >> >> Did you get my below mail? Should I post this to the tech list? > >> >> > >> >> On 10/8/06, bbackde at googlemail.com <bbackde at googlemail.com> wrote: > >> >> >The node now uses the filename of a chk key automatically if dda is > >> >used. > >> >> >This is bad! Apps like frost using insert on demand need the same chk > >> >> >key for the same file, no matter what filename the user gave to the > >> >> >file. the different filenames are handled by frost and set to the > >file > >> >> >upon download! > >> >> >If frost uses dda and 2 user insert the same file but with different > >> >> >names the we have 2 chk keys in our file sharing system for the same > >> >> >file, that must not happen. > >> >> > > >> >> >So the implementation should take care of this. If a filename is > >> >> >explicitely given in fcp2 then the filename can be used. If no > >> >> >filename is given the node must not use the filename of the dda file! > >> >> >This was implemented for thaw, but there are more apps than thaw and > >> >> >e.g. frost cannot work with this behaviour. Please fix. > >> >> > > >> >> > >> > > >> > > >> >-----BEGIN PGP SIGNATURE----- > >> >Version: GnuPG v1.4.5 (GNU/Linux) > >> > > >> >iD8DBQFFK67uA9rUluQ9pFARAhRYAJ9wXtuMPktJ6M38dUjgIJ8V5J2T7gCaA0ps > >> >C/CHgC6b2qvy+gyb6ZPAwrc= > >> >=061t > >> >-----END PGP SIGNATURE----- > >> > > >> > > >> > > >> > > > > > >-----BEGIN PGP SIGNATURE----- > >Version: GnuPG v1.4.5 (GNU/Linux) > > > >iD8DBQFFK7q4A9rUluQ9pFARApfGAJ49Qiqc4staBeZ7hNL5DRMMi9wLVwCgqb87 > >8QyPY3vM0hMlJqaSU/Wf+x4= > >=QPUz > >-----END PGP SIGNATURE----- > > > > > > > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: Digital signature URL: <https://emu.freenetproject.org/pipermail/tech/attachments/20061010/0e6d4427/attachment.pgp>
