On Sun, Jul 19, 2009 at 08:55:52PM +0100, Stuart Henderson wrote:
> systat's default was changed to display names numerically,
> Can says this was to avoid excessive blocking with the default
> displays. However this left behind an ineffective -n flag and
> no way to show names from the command-line (though there is
> a yet-to-be-documented keyboard command to toggle this, 'n').
>
> This diff adds -N to show names (keeping -n as is, it didn't
> seem right to make -n behave oppositely from netstat).
>
> ok?
>
this seems like jumping through hoops.
we have a fair few apps (route,arp,netstat) that have -n to disable the
lookup. systat has it too, but now it;s on by default. your solution
means we have one extra option (-N), plus a useless option (-n).
isn;t the "solution" that you set an alias if you want -n by default? or
should we do this for all apps with -n?
anyway, if it goes ahead, one comment below:
> Index: main.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/systat/main.c,v
> retrieving revision 1.54
> diff -u -p -r1.54 main.c
> --- main.c 25 Jun 2009 20:45:43 -0000 1.54
> +++ main.c 19 Jul 2009 19:45:00 -0000
> @@ -197,7 +197,7 @@ void
> usage(void)
> {
> extern char *__progname;
> - fprintf(stderr, "usage: %s [-abin] [-d count] "
> + fprintf(stderr, "usage: %s [-abinN] [-d count] "
N before n.
jmc
