On Fri, 09 Oct 2009, Bret S. Lambert wrote:
> In light of the above, the following...
>
> > +#define USB_PRODUCT_TCTMOBILE_f000 0xf000 /* TCT Mobile
> > International Ltd. f000 */
> > +#define USB_PRODUCT_TCTMOBILE_0000 0x0000 /* TCT Mobile
> > International Ltd. 0000 */
>
> ...should probably have names which describe modes, instead of values,
> such as _UMSM or UMASS vice _f000 and _0000.
Index: umsm.c
===================================================================
RCS file: /cvs/src/sys/dev/usb/umsm.c,v
retrieving revision 1.49
diff -N -u -p umsm.c
--- umsm.c 7 Sep 2009 20:26:13 -0000 1.49
+++ umsm.c 9 Oct 2009 08:49:08 -0000
@@ -199,6 +199,9 @@ static const struct umsm_type umsm_devs[] = {
{{ USB_VENDOR_SIERRA, USB_PRODUCT_SIERRA_AC885U }, 0},
{{ USB_VENDOR_SIERRA, USB_PRODUCT_SIERRA_TRUINSTALL }, DEV_TRUINSTALL},
+ {{ USB_VENDOR_TCTMOBILE, USB_PRODUCT_TCTMOBILE_UMASS }, DEV_UMASS3},
+ {{ USB_VENDOR_TCTMOBILE, USB_PRODUCT_TCTMOBILE_UMSM }, 0},
+
{{ USB_VENDOR_HP, USB_PRODUCT_HP_HS2300 }, 0},
{{ USB_VENDOR_CMOTECH, USB_PRODUCT_CMOTECH_CNU510 }, 0}, /* ??? */
Index: usbdevs
===================================================================
RCS file: /cvs/src/sys/dev/usb/usbdevs,v
retrieving revision 1.451
diff -N -u -p usbdevs
--- usbdevs 20 Sep 2009 12:53:36 -0000 1.451
+++ usbdevs 9 Oct 2009 08:49:09 -0000
@@ -527,6 +527,7 @@ vendor MEINBERG 0x1938 Meinberg Funkuhren
vendor QUALCOMM3 0x19d2 Qualcomm Inc.
vendor QUANTA 0x1a32 Quanta
vendor WCH2 0x1a86 QinHeng Electronics
+vendor TCTMOBILE 0x1bbb TCT Mobile International Ltd.
vendor LONGCHEER 0x1c9e Longcheer Technology
vendor PEGATRON 0x1d4d Pegatron
vendor AIRTIES 0x1eda AirTies
@@ -2939,6 +2940,10 @@ product SWEEX ZD1211 0x1809 ZD1211
/* Syntech Information products */
product SYNTECH SERIAL 0x0001 Serial
+
+/* TCT Mobile International Ltd. products */
+product TCTMOBILE UMASS 0xf000 TCT Mobile International Ltd.
Storage mode
+product TCTMOBILE UMSM 0x0000 TCT Mobile International Ltd. Modem mode
/* Tangtop products */
product TANGTOP USBPS2 0x0001 USBPS2
Index: usbdevs.h
===================================================================
RCS file: /cvs/src/sys/dev/usb/usbdevs.h,v
retrieving revision 1.461
diff -N -u -p usbdevs.h
--- usbdevs.h 20 Sep 2009 12:53:51 -0000 1.461
+++ usbdevs.h 9 Oct 2009 08:49:11 -0000
@@ -534,6 +534,7 @@
#define USB_VENDOR_QUALCOMM3 0x19d2 /* Qualcomm Inc. */
#define USB_VENDOR_QUANTA 0x1a32 /* Quanta */
#define USB_VENDOR_WCH2 0x1a86 /* QinHeng Electronics */
+#define USB_VENDOR_TCTMOBILE 0x1bbb /* TCT Mobile
International Ltd. */
#define USB_VENDOR_LONGCHEER 0x1c9e /* Longcheer Technology
*/
#define USB_VENDOR_PEGATRON 0x1d4d /* Pegatron */
#define USB_VENDOR_AIRTIES 0x1eda /* AirTies */
@@ -2946,6 +2947,10 @@
/* Syntech Information products */
#define USB_PRODUCT_SYNTECH_SERIAL 0x0001 /* Serial */
+
+/* TCT Mobile International Ltd. products */
+#define USB_PRODUCT_TCTMOBILE_UMASS 0xf000 /* TCT Mobile
International Ltd. Storage mode */
+#define USB_PRODUCT_TCTMOBILE_UMSM 0x0000 /* TCT Mobile
International Ltd. Modem mode */
/* Tangtop products */
#define USB_PRODUCT_TANGTOP_USBPS2 0x0001 /* USBPS2 */
Index: usbdevs_data.h
===================================================================
RCS file: /cvs/src/sys/dev/usb/usbdevs_data.h,v
retrieving revision 1.455
diff -N -u -p usbdevs_data.h
--- usbdevs_data.h 20 Sep 2009 12:53:51 -0000 1.455
+++ usbdevs_data.h 9 Oct 2009 08:49:12 -0000
@@ -6734,6 +6734,14 @@ const struct usb_known_product usb_known_products[] =
"Serial",
},
{
+ USB_VENDOR_TCTMOBILE, USB_PRODUCT_TCTMOBILE_UMASS,
+ "TCT Mobile International Ltd. Storage mode",
+ },
+ {
+ USB_VENDOR_TCTMOBILE, USB_PRODUCT_TCTMOBILE_UMSM,
+ "TCT Mobile International Ltd. Modem mode",
+ },
+ {
USB_VENDOR_TANGTOP, USB_PRODUCT_TANGTOP_USBPS2,
"USBPS2",
},
@@ -9316,6 +9324,10 @@ const struct usb_known_vendor usb_known_vendors[] = {
{
USB_VENDOR_WCH2,
"QinHeng Electronics",
+ },
+ {
+ USB_VENDOR_TCTMOBILE,
+ "TCT Mobile International Ltd.",
},
{
USB_VENDOR_LONGCHEER,
