On Tue, Jun 01, 2010 at 04:12:19AM +0200, Dawe wrote:
> ber_calc_len() is not an internal function in snmpd(8) and ypldap(8).
> It's used this way in ldapd(8), but it's likely better to keep the binding 
> consistent.

fixed, thanks

        -martin


> Index: ldapd/ber.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ldapd/ber.c,v
> retrieving revision 1.1
> diff -u -p -r1.1 ber.c
> --- ldapd/ber.c       31 May 2010 17:36:31 -0000      1.1
> +++ ldapd/ber.c       1 Jun 2010 01:50:06 -0000
> @@ -819,10 +819,6 @@ ber_free_elements(struct ber_element *ro
>       free(root);
>  }
>  
> -/*
> - * internal functions
> - */
> -
>  size_t
>  ber_calc_len(struct ber_element *root)
>  {
> @@ -853,6 +849,10 @@ ber_calc_len(struct ber_element *root)
>  
>       return (root->be_len + size);
>  }
> +
> +/*
> + * internal functions
> + */
>  
>  static int
>  ber_dump_element(struct ber *ber, struct ber_element *root)
> Index: snmpd/ber.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/snmpd/ber.c,v
> retrieving revision 1.20
> diff -u -p -r1.20 ber.c
> --- snmpd/ber.c       24 Feb 2010 14:09:45 -0000      1.20
> +++ snmpd/ber.c       1 Jun 2010 01:50:06 -0000
> @@ -823,10 +823,6 @@ ber_free_elements(struct ber_element *ro
>       free(root);
>  }
>  
> -/*
> - * internal functions
> - */
> -
>  size_t
>  ber_calc_len(struct ber_element *root)
>  {
> @@ -857,6 +853,10 @@ ber_calc_len(struct ber_element *root)
>  
>       return (root->be_len + size);
>  }
> +
> +/*
> + * internal functions
> + */
>  
>  static int
>  ber_dump_element(struct ber *ber, struct ber_element *root)
> Index: ypldap/ber.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ypldap/ber.c,v
> retrieving revision 1.5
> diff -u -p -r1.5 ber.c
> --- ypldap/ber.c      24 Feb 2010 14:09:45 -0000      1.5
> +++ ypldap/ber.c      1 Jun 2010 01:50:06 -0000
> @@ -823,10 +823,6 @@ ber_free_elements(struct ber_element *ro
>       free(root);
>  }
>  
> -/*
> - * internal functions
> - */
> -
>  size_t
>  ber_calc_len(struct ber_element *root)
>  {
> @@ -857,6 +853,10 @@ ber_calc_len(struct ber_element *root)
>  
>       return (root->be_len + size);
>  }
> +
> +/*
> + * internal functions
> + */
>  
>  static int
>  ber_dump_element(struct ber *ber, struct ber_element *root)

Reply via email to