On 2010/06/16 20:19, Patrick Coleman wrote: > >> > > > > trunk(4) places trunkports into promiscuous mode anyway, > > so would it make more sense just to skip the IFF_PROMISC > > check here? in which case, there would be no need to > > preserve ifp_orig. > > That makes sense. I wasn't sure if that promiscuous check was there > for another reason, so I erred on the side of leaving it in.
oh, of course, this check isn't only used for trunk... I think we need to wait until Claudio's around for his input and do some testing in various scenarios. This whole block was added in r1.28 when bridge(4) was added. > Updated patch at > http://patrick.ld.net.au/20100616-fix-gratuitous-reset-nopromisc.patch. > I've also created bug 6404/kernel. > > Cheers, > > Patrick > > -- > http://www.labyrinthdata.net.au - WA Backup, Web and VPS Hosting
