Hi Adding the multiple inclusion stuff is right, thanks.
I don't think we need to include sys/queue.h in imsg.h - the man page documents that you should include sys/types.h and sys/queue.h yourself. On Tue, Jun 22, 2010 at 10:40:45PM -0300, Christiano F. Haesbaert wrote: > Also a missing include. > > Index: imsg.h > =================================================================== > RCS file: /cvs/src/lib/libutil/imsg.h,v > retrieving revision 1.1 > diff -d -u -p -w imsg.h > --- imsg.h 26 May 2010 16:44:32 -0000 1.1 > +++ imsg.h 23 Jun 2010 01:36:28 -0000 > @@ -18,6 +18,11 @@ > * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. > */ > > +#ifndef IMSG_H > +#define IMSG_H > + > +#include <sys/queue.h> > + > #define IBUF_READ_SIZE 65535 > #define IMSG_HEADER_SIZE sizeof(struct imsg_hdr) > #define MAX_IMSGSIZE 16384 > @@ -105,3 +110,5 @@ void imsg_close(struct imsgbuf *, struct ibuf *); > void imsg_free(struct imsg *); > int imsg_flush(struct imsgbuf *); > void imsg_clear(struct imsgbuf *); > + > +#endif
