On Sat, Sep 11, 2010 at 08:05:54PM +0200, Mark Kettenis wrote: > > Date: Sat, 11 Sep 2010 13:58:17 -0400 > > From: Kenneth R Westerback <[email protected]> > > > > Blocks == DEV_BSIZE == 512 bytes, and are the units of buf's. > > > > Sectors == the size of the addressing unit and length of physical > > device i/o's to SCSI devices. > > > > Adjust variable names to reflect this and reduce confusion. > > > > No change to .o files. > > > > Unless there are quick aesthetic/philosophical objections I will > > be committing this tonight. But ok's are nice. > > Sorry, but I don't think this makes a lot of sense. Both the SCSI and > the ATA standard talk about (logical) blocks. Sectors are something > from the past, when people used spinning disks of magnetic media to > store bits ;).
Perhaps, but we have been drawing a distinction between block size (always 512 bytes) and <unit name of your choice>-size for the physical devices. Sectors is, as you say, the historical choice for the latter. We use it extensively in code and docs. In my opinion it is a fine name and we do need a consistant name to reduce the DEV_BSIZE vs Physical address/size units confusion. I'm happy to entertain alternatives. Logical Blocks vs Physical Blocks doesn't help as much to make clear they are two different units. .... Ken
