I just had a dream there could be a problem at 812,821
instead of
fprintf(stderr,"BIOCCREATERAID\n");
return -1;
it should stay
err(1, "BIOCCREATERAID");
And I've also forgotten to s/again/repeat
Sorry, I'm sending a new patch
On Saturday 11 September 2010 22:50:14 you wrote:
> Hi all,
>
> I wrote a bioctl patch that adds support to infinite password loop
> (infinite till you write the correct password).
> This option is called by -F parameter (don't know why exactly I have
> selected this one, but I think it's acceptable and logic ("force" me
> to write the correct password)).
>
> For all changes please take a look at patch. I just have some little
> comments here
> 71,77 - I saw lot of functions (including bio_createraid(u_int16_t,
> char *, char *)) are 'void' - so I had to change it to int.
> 240,253 - not sure if the formatting is correct, but should be
> 812,821 - is there any function that prints error plus returns a
> value? I had to remove errx and err from here and replace it by
> fprintf,return.
>
> Cold you please review the code and write what's wrong?
>
> Thanks,
> Merlyn
--
merlyn <[email protected]>,<[email protected]>
OpenBSD ufo.merlyn.cz 4.8 GENERIC#1 i386
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
[demime 1.01d removed an attachment of type text/x-diff which had a name of
patch_bioctl_F.patch]
